diff options
| author | Matthieu Moy <Matthieu.Moy@imag.fr> | 2010-08-05 12:05:22 +0200 |
|---|---|---|
| committer | Pat Thoyts <patthoyts@users.sourceforge.net> | 2010-08-12 21:35:09 +0100 |
| commit | 62f9a632c819bd53a5b7dbe40409ab086a4bce10 (patch) | |
| tree | 6fd7855db671a1f80ff8e9043198ad8604b1de43 /lib | |
| parent | git-gui: display error launching blame as a message box. (diff) | |
| download | git-62f9a632c819bd53a5b7dbe40409ab086a4bce10.tar.gz git-62f9a632c819bd53a5b7dbe40409ab086a4bce10.zip | |
git-gui: use shell to launch textconv filter in "blame"
The textconv filters may include multiple arguments and may make use
of unix shell features. To maintain compatibility with 'git blame'
ensure these commands are passed through bash.
Reported-by: Kirill Smelkov <kirr@landau.phys.spbu.ru>
Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/blame.tcl | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/lib/blame.tcl b/lib/blame.tcl index 2137ec9684..77656d3675 100644 --- a/lib/blame.tcl +++ b/lib/blame.tcl @@ -460,7 +460,9 @@ method _load {jump} { } if {$commit eq {}} { if {$do_textconv ne 0} { - set fd [open |[list $textconv $path] r] + # Run textconv with sh -c "..." to allow it to + # contain command + arguments. + set fd [open |[list [shellpath] -c "$textconv \"\$0\"" $path] r] } else { set fd [open $path r] } |