diff options
| author | Lidong Yan <502024330056@smail.nju.edu.cn> | 2025-07-01 05:32:08 +0000 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2025-07-01 14:41:53 -0700 |
| commit | 73bf771b958b0d28fc5839cd94c4b7ad2029f631 (patch) | |
| tree | 62499730568e43ccaab54077b4b93babf35c26b3 /pack-bitmap.c | |
| parent | pack-bitmap: fix memory leak if load_bitmap() failed (diff) | |
| download | git-73bf771b958b0d28fc5839cd94c4b7ad2029f631.tar.gz git-73bf771b958b0d28fc5839cd94c4b7ad2029f631.zip | |
pack-bitmap: reword comments in test_bitmap_commits()
The comment in pack-bitmap.c:test_bitmap_commits(), suggests that
we can avoid reading the commit table altogether. However, this
comment is misleading. The reason we load bitmap entries here is
because test_bitmap_commits() needs to print the commit IDs from the
bitmap, and we must read the bitmap entries to obtain those commit IDs.
So reword this comment.
Signed-off-by: Lidong Yan <502024330056@smail.nju.edu.cn>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'pack-bitmap.c')
| -rw-r--r-- | pack-bitmap.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/pack-bitmap.c b/pack-bitmap.c index fd19c22551..d1d8814be7 100644 --- a/pack-bitmap.c +++ b/pack-bitmap.c @@ -2839,8 +2839,9 @@ int test_bitmap_commits(struct repository *r) die(_("failed to load bitmap indexes")); /* - * As this function is only used to print bitmap selected - * commits, we don't have to read the commit table. + * Since this function needs to print the bitmapped + * commits, bypass the commit lookup table (if one exists) + * by forcing the bitmap to eagerly load its entries. */ if (bitmap_git->table_lookup) { if (load_bitmap_entries_v1(bitmap_git) < 0) |