diff options
| author | Taylor Blau <me@ttaylorr.com> | 2023-12-14 17:23:39 -0500 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2023-12-14 14:38:07 -0800 |
| commit | 66f0c71073ee5fe1c9d12d2952305a4793d7b43f (patch) | |
| tree | 240dbb9ba6246592470e7d8d78a35dd24319ad27 /pack-objects.h | |
| parent | Start the 2.44 cycle (diff) | |
| download | git-66f0c71073ee5fe1c9d12d2952305a4793d7b43f.tar.gz git-66f0c71073ee5fe1c9d12d2952305a4793d7b43f.zip | |
pack-objects: free packing_data in more places
The pack-objects internals use a packing_data struct to track what
objects are part of the pack(s) being formed.
Since these structures contain allocated fields, failing to
appropriately free() them results in a leak. Plug that leak by
introducing a clear_packing_data() function, and call it in the
appropriate spots.
This is a fairly straightforward leak to plug, since none of the callers
expect to read any values or have any references to parts of the address
space being freed.
Signed-off-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'pack-objects.h')
| -rw-r--r-- | pack-objects.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/pack-objects.h b/pack-objects.h index 0d78db40cb..b9898a4e64 100644 --- a/pack-objects.h +++ b/pack-objects.h @@ -169,6 +169,7 @@ struct packing_data { }; void prepare_packing_data(struct repository *r, struct packing_data *pdata); +void clear_packing_data(struct packing_data *pdata); /* Protect access to object database */ static inline void packing_data_lock(struct packing_data *pdata) |