diff options
| author | Qianfeng Rong <rongqianfeng@vivo.com> | 2025-08-28 16:13:10 +0800 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2025-08-28 10:35:09 +0200 |
| commit | 4ef353d546cda466fc39b7daca558d7bcec21c09 (patch) | |
| tree | ef4450faea7be1d0f06a6a4e3e62a9b42961c58f | |
| parent | ALSA: pcm: oss: Use guard() for spin locks (diff) | |
| download | linux-4ef353d546cda466fc39b7daca558d7bcec21c09.tar.gz linux-4ef353d546cda466fc39b7daca558d7bcec21c09.zip | |
ALSA: lx_core: use int type to store negative error codes
Change the 'ret' variable from u16 to int to store negative error codes or
zero returned by lx_message_send_atomic().
Storing the negative error codes in unsigned type, doesn't cause an issue
at runtime but it's ugly as pants. Additionally, assigning negative error
codes to unsigned type may trigger a GCC warning when the -Wsign-conversion
flag is enabled.
No effect on runtime.
Fixes: 02bec4904508 ("ALSA: lx6464es - driver for the digigram lx6464es interface")
Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Link: https://patch.msgid.link/20250828081312.393148-1-rongqianfeng@vivo.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
| -rw-r--r-- | sound/pci/lx6464es/lx_core.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sound/pci/lx6464es/lx_core.c b/sound/pci/lx6464es/lx_core.c index 9d95ecb299ae..a99acd1125e7 100644 --- a/sound/pci/lx6464es/lx_core.c +++ b/sound/pci/lx6464es/lx_core.c @@ -316,7 +316,7 @@ polling_successful: /* low-level dsp access */ int lx_dsp_get_version(struct lx6464es *chip, u32 *rdsp_version) { - u16 ret; + int ret; mutex_lock(&chip->msg_lock); @@ -330,10 +330,10 @@ int lx_dsp_get_version(struct lx6464es *chip, u32 *rdsp_version) int lx_dsp_get_clock_frequency(struct lx6464es *chip, u32 *rfreq) { - u16 ret = 0; u32 freq_raw = 0; u32 freq = 0; u32 frequency = 0; + int ret; mutex_lock(&chip->msg_lock); |