diff options
| author | Kexin Sun <kexinsun@smail.nju.edu.cn> | 2026-03-21 18:59:40 +0800 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2026-03-23 18:11:00 +0000 |
| commit | a37fb5166be943fa78962f77db00ce5a25366e87 (patch) | |
| tree | eaadd7a165b0494f5e5b11c17d4bd6ec43751af3 | |
| parent | 9861e15f6347dcce65795b8dd680b491a54d59a9 (diff) | |
| download | linux-a37fb5166be943fa78962f77db00ce5a25366e87.tar.gz linux-a37fb5166be943fa78962f77db00ce5a25366e87.zip | |
spi: pl022: update outdated references to pump_transfers()
The pump_transfers tasklet was removed when the driver
switched to the SPI core message processing loop in commit
9b2ef250b31d ("spi: spl022: switch to use default
spi_transfer_one_message()"). The kdoc of
pl022_interrupt_handler() still describes the old flow: scheduling
the pump_transfers tasklet, calling giveback(), and flagging
STATE_ERROR — none of which exist in the current code. Rewrite
the kdoc to reflect the current paths, which flag errors via
SPI_TRANS_FAIL_IO and call spi_finalize_current_transfer()
directly.
Assisted-by: unnamed:deepseek-v3.2 coccinelle
Signed-off-by: Kexin Sun <kexinsun@smail.nju.edu.cn>
Reviewed-by: Linus Walleij <linusw@kernel.org>
Link: https://patch.msgid.link/20260321105940.8143-1-kexinsun@smail.nju.edu.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | drivers/spi/spi-pl022.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c index c82cc522776d..bd1d28caa51e 100644 --- a/drivers/spi/spi-pl022.c +++ b/drivers/spi/spi-pl022.c @@ -1127,11 +1127,11 @@ static inline void pl022_dma_remove(struct pl022 *pl022) * * This function handles interrupts generated for an interrupt based transfer. * If a receive overrun (ROR) interrupt is there then we disable SSP, flag the - * current message's state as STATE_ERROR and schedule the tasklet - * pump_transfers which will do the postprocessing of the current message by - * calling giveback(). Otherwise it reads data from RX FIFO till there is no - * more data, and writes data in TX FIFO till it is not full. If we complete - * the transfer we move to the next transfer and schedule the tasklet. + * current transfer with SPI_TRANS_FAIL_IO and call + * spi_finalize_current_transfer() to let the core finish the message. + * Otherwise it reads data from RX FIFO till there is no more data, and writes + * data in TX FIFO till it is not full. When the transfer is complete we call + * spi_finalize_current_transfer() so the core can schedule the next one. */ static irqreturn_t pl022_interrupt_handler(int irq, void *dev_id) { |