aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJohannes Berg <johannes.berg@intel.com>2022-09-02 16:12:59 +0200
committerJohannes Berg <johannes.berg@intel.com>2022-09-03 16:57:01 +0200
commitae960ee90bb1c171c2e4c8d2107bb1c693a835dc (patch)
tree9c5aac75a4666cc56277ac3b2dfeb7b00e4ab939
parentwifi: move from strlcpy with unused retval to strscpy (diff)
downloadlinux-ae960ee90bb1c171c2e4c8d2107bb1c693a835dc.tar.gz
linux-ae960ee90bb1c171c2e4c8d2107bb1c693a835dc.zip
wifi: mac80211: prevent VLANs on MLDs
Do not allow VLANs to be added to AP interfaces that are MLDs, this isn't going to work because the link structs aren't propagated to the VLAN interfaces yet. Signed-off-by: Johannes Berg <johannes.berg@intel.com> Link: https://lore.kernel.org/r/20220902161144.8c88531146e9.If2ef9a3b138d4f16ed2fda91c852da156bdf5e4d@changeid Signed-off-by: Johannes Berg <johannes.berg@intel.com>
-rw-r--r--net/mac80211/iface.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c
index 14505278073a..7d4a1b0cee73 100644
--- a/net/mac80211/iface.c
+++ b/net/mac80211/iface.c
@@ -296,6 +296,11 @@ static int ieee80211_check_concurrent_iface(struct ieee80211_sub_if_data *sdata,
nsdata->vif.type))
return -ENOTUNIQ;
+ /* No support for VLAN with MLO yet */
+ if (iftype == NL80211_IFTYPE_AP_VLAN &&
+ nsdata->wdev.use_4addr)
+ return -EOPNOTSUPP;
+
/*
* can only add VLANs to enabled APs
*/