diff options
| author | Alok Tiwari <alok.a.tiwari@oracle.com> | 2025-10-31 09:15:53 -0700 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2025-11-03 16:20:03 -0800 |
| commit | b2b526c2cf57d14ee269e012ed179081871f45a1 (patch) | |
| tree | 256a1c2db4580301d670977c2679cabacb10c548 | |
| parent | netconsole: Acquire su_mutex before navigating configs hierarchy (diff) | |
| download | linux-b2b526c2cf57d14ee269e012ed179081871f45a1.tar.gz linux-b2b526c2cf57d14ee269e012ed179081871f45a1.zip | |
net: mdio: Check regmap pointer returned by device_node_to_regmap()
The call to device_node_to_regmap() in airoha_mdio_probe() can return
an ERR_PTR() if regmap initialization fails. Currently, the driver
stores the pointer without validation, which could lead to a crash
if it is later dereferenced.
Add an IS_ERR() check and return the corresponding error code to make
the probe path more robust.
Fixes: 67e3ba978361 ("net: mdio: Add MDIO bus controller for Airoha AN7583")
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20251031161607.58581-1-alok.a.tiwari@oracle.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rw-r--r-- | drivers/net/mdio/mdio-airoha.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/mdio/mdio-airoha.c b/drivers/net/mdio/mdio-airoha.c index 1dc9939c8d7d..52e7475121ea 100644 --- a/drivers/net/mdio/mdio-airoha.c +++ b/drivers/net/mdio/mdio-airoha.c @@ -219,6 +219,8 @@ static int airoha_mdio_probe(struct platform_device *pdev) priv = bus->priv; priv->base_addr = addr; priv->regmap = device_node_to_regmap(dev->parent->of_node); + if (IS_ERR(priv->regmap)) + return PTR_ERR(priv->regmap); priv->clk = devm_clk_get_enabled(dev, NULL); if (IS_ERR(priv->clk)) |