diff options
| author | Tomas Glozar <tglozar@redhat.com> | 2026-03-10 17:07:25 +0100 |
|---|---|---|
| committer | Tomas Glozar <tglozar@redhat.com> | 2026-03-20 14:41:36 +0100 |
| commit | be8058f31b4e237604e4ce7599593ab68dc69ae7 (patch) | |
| tree | b1f60baec9ff54355ee064eb42d972cb21a2a501 | |
| parent | 99261ccdc0f346b1f21ae3718b2b3c0dd69c04b4 (diff) | |
| download | linux-be8058f31b4e237604e4ce7599593ab68dc69ae7.tar.gz linux-be8058f31b4e237604e4ce7599593ab68dc69ae7.zip | |
rtla: Fix segfault on multiple SIGINTs
Detach stop_trace() from SIGINT/SIGALRM on tool clean-up to prevent it
from crashing RTLA by accessing freed memory.
This prevents a crash when multiple SIGINTs are received.
Fixes: d6899e560366 ("rtla/timerlat_hist: Abort event processing on second signal")
Fixes: 80967b354a76 ("rtla/timerlat_top: Abort event processing on second signal")
Reviewed-by: Wander Lairson Costa <wander@redhat.com>
Link: https://lore.kernel.org/r/20260310160725.144443-1-tglozar@redhat.com
Signed-off-by: Tomas Glozar <tglozar@redhat.com>
| -rw-r--r-- | tools/tracing/rtla/src/common.c | 16 |
1 files changed, 15 insertions, 1 deletions
diff --git a/tools/tracing/rtla/src/common.c b/tools/tracing/rtla/src/common.c index 50d8aafdfd3b..35e3d3aa922e 100644 --- a/tools/tracing/rtla/src/common.c +++ b/tools/tracing/rtla/src/common.c @@ -42,6 +42,18 @@ static void set_signals(struct common_params *params) } /* + * unset_signals - unsets the signals to stop the tool + */ +static void unset_signals(struct common_params *params) +{ + signal(SIGINT, SIG_DFL); + if (params->duration) { + alarm(0); + signal(SIGALRM, SIG_DFL); + } +} + +/* * getopt_auto - auto-generates optstring from long_options */ int getopt_auto(int argc, char **argv, const struct option *long_opts) @@ -351,7 +363,7 @@ int run_tool(struct tool_ops *ops, int argc, char *argv[]) retval = ops->main(tool); if (retval) - goto out_trace; + goto out_signals; if (params->user_workload && !params->user.stopped_running) { params->user.should_run = 0; @@ -373,6 +385,8 @@ int run_tool(struct tool_ops *ops, int argc, char *argv[]) if (ops->analyze) ops->analyze(tool, stopped); +out_signals: + unset_signals(params); out_trace: trace_events_destroy(&tool->record->trace, params->events); params->events = NULL; |