summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKent Overstreet <kent.overstreet@gmail.com>2022-03-15 16:40:55 -0400
committerKent Overstreet <kent.overstreet@linux.dev>2023-10-22 17:09:29 -0400
commitd905f67ec89fda758bcfa70d0b5c3d3006bbdb3e (patch)
tree4629749a19b97bc0c2a8992cfadff13789898138
parent70a9953c424ccba616a3b74368780de13a80dabd (diff)
downloadlinux-d905f67ec89fda758bcfa70d0b5c3d3006bbdb3e.tar.gz
linux-d905f67ec89fda758bcfa70d0b5c3d3006bbdb3e.zip
bcachefs: Copygc allocations shouldn't be nowait
We don't actually want copygc allocations to be nowait - an allocation for copygc might fail and then later succeed due to a bucket needing to wait on journal commit, or to be discarded. Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
-rw-r--r--fs/bcachefs/move.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/bcachefs/move.c b/fs/bcachefs/move.c
index 3a5c81f3697b..a219c10a7135 100644
--- a/fs/bcachefs/move.c
+++ b/fs/bcachefs/move.c
@@ -352,7 +352,6 @@ int bch2_migrate_write_init(struct bch_fs *c, struct migrate_write *m,
if (m->data_opts.btree_insert_flags & BTREE_INSERT_USE_RESERVE) {
m->op.alloc_reserve = RESERVE_movinggc;
- m->op.flags |= BCH_WRITE_ALLOC_NOWAIT;
} else {
/* XXX: this should probably be passed in */
m->op.flags |= BCH_WRITE_ONLY_SPECIFIED_DEVS;