diff options
| author | Aleksander Jan Bajkowski <olek2@wp.pl> | 2026-04-06 22:12:12 +0200 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2026-04-08 19:17:17 -0700 |
| commit | dbc2bb4e8742068d3d3dc8ebb46d874e5fd953b8 (patch) | |
| tree | e5d07507a2c483692ada41d4f789ff1054c9b87a | |
| parent | f81f4e79b192be6c43abb256ea7da3a7dfb7899d (diff) | |
| download | linux-dbc2bb4e8742068d3d3dc8ebb46d874e5fd953b8.tar.gz linux-dbc2bb4e8742068d3d3dc8ebb46d874e5fd953b8.zip | |
net: phy: realtek: get rid of magic numbers in rtl8201_config_intr()
Replace the magic numbers with defines. Register names were obtained from
publicly available documentation[1]. This should make it clear what's going
on in the code.
1. RTL8201F/RTL8201FL/RTL8201FN Rev. 1.4 Datasheet
Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
Reviewed-by: Daniel Golle <daniel@makrotopia.org>
Reviewed-by: Nicolai Buchwitz nb@tipi-net.de
Link: https://patch.msgid.link/20260406201222.1043396-1-olek2@wp.pl
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rw-r--r-- | drivers/net/phy/realtek/realtek_main.c | 15 |
1 files changed, 12 insertions, 3 deletions
diff --git a/drivers/net/phy/realtek/realtek_main.c b/drivers/net/phy/realtek/realtek_main.c index 023e47ad605b..c3604e1c45d9 100644 --- a/drivers/net/phy/realtek/realtek_main.c +++ b/drivers/net/phy/realtek/realtek_main.c @@ -22,7 +22,14 @@ #include "../phylib.h" #include "realtek.h" +#define RTL8201F_IER_PAGE 0x07 #define RTL8201F_IER 0x13 +#define RTL8201F_IER_LINK BIT(13) +#define RTL8201F_IER_DUPLEX BIT(12) +#define RTL8201F_IER_ANERR BIT(11) +#define RTL8201F_IER_MASK (RTL8201F_IER_ANERR | \ + RTL8201F_IER_DUPLEX | \ + RTL8201F_IER_LINK) #define RTL8201F_ISR 0x1e #define RTL8201F_ISR_ANERR BIT(15) @@ -349,11 +356,13 @@ static int rtl8201_config_intr(struct phy_device *phydev) if (err) return err; - val = BIT(13) | BIT(12) | BIT(11); - err = phy_write_paged(phydev, 0x7, RTL8201F_IER, val); + val = RTL8201F_IER_MASK; + err = phy_write_paged(phydev, RTL8201F_IER_PAGE, + RTL8201F_IER, val); } else { val = 0; - err = phy_write_paged(phydev, 0x7, RTL8201F_IER, val); + err = phy_write_paged(phydev, RTL8201F_IER_PAGE, + RTL8201F_IER, val); if (err) return err; |