diff options
| author | JP Kobryn <inwardvessel@gmail.com> | 2025-05-14 17:19:35 -0700 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2025-05-19 10:29:42 -1000 |
| commit | 748922dcfabdd655d25fb6dd09a60e694a3d35e6 (patch) | |
| tree | bac6da9c031fab4a6d40efa2a4feb0494cda38d6 /block | |
| parent | cgroup: use separate rstat trees for each subsystem (diff) | |
| download | linux-748922dcfabdd655d25fb6dd09a60e694a3d35e6.tar.gz linux-748922dcfabdd655d25fb6dd09a60e694a3d35e6.zip | |
cgroup: use subsystem-specific rstat locks to avoid contention
It is possible to eliminate contention between subsystems when
updating/flushing stats by using subsystem-specific locks. Let the existing
rstat locks be dedicated to the cgroup base stats and rename them to
reflect that. Add similar locks to the cgroup_subsys struct for use with
individual subsystems.
Lock initialization is done in the new function ss_rstat_init(ss) which
replaces cgroup_rstat_boot(void). If NULL is passed to this function, the
global base stat locks will be initialized. Otherwise, the subsystem locks
will be initialized.
Change the existing lock helper functions to accept a reference to a css.
Then within these functions, conditionally select the appropriate locks
based on the subsystem affiliation of the given css. Add helper functions
for this selection routine to avoid repeated code.
Signed-off-by: JP Kobryn <inwardvessel@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'block')
| -rw-r--r-- | block/blk-cgroup.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c index 0560ea402856..4dc10c1e97a4 100644 --- a/block/blk-cgroup.c +++ b/block/blk-cgroup.c @@ -1074,8 +1074,8 @@ static void __blkcg_rstat_flush(struct blkcg *blkcg, int cpu) /* * For covering concurrent parent blkg update from blkg_release(). * - * When flushing from cgroup, cgroup_rstat_lock is always held, so - * this lock won't cause contention most of time. + * When flushing from cgroup, the subsystem rstat lock is always held, + * so this lock won't cause contention most of time. */ raw_spin_lock_irqsave(&blkg_stat_lock, flags); |