aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/android
diff options
context:
space:
mode:
authorChristian Brauner <brauner@kernel.org>2025-03-19 09:39:47 +0100
committerChristian Brauner <brauner@kernel.org>2025-04-08 11:24:42 +0200
commit4e5c53e03806359e68dde5e951e50cd1f4908405 (patch)
tree67a4582f8919749bca19da68d9af988dce975773 /drivers/android
parentLinux 6.15-rc1 (diff)
parentVFS: change lookup_one_common and lookup_noperm_common to take a qstr (diff)
downloadlinux-4e5c53e03806359e68dde5e951e50cd1f4908405.tar.gz
linux-4e5c53e03806359e68dde5e951e50cd1f4908405.zip
Merge patch series "VFS: improve interface for lookup_one functions"
NeilBrown <neil@brown.name> says: VFS has some functions with names containing "lookup_one_len" and others without the "_len". This difference has nothing to do with "len". This is an historical accident but can be confusing. The functions without "_len" take a "mnt_idmap" pointer. This is found in the "vfsmount" and that is an important question when choosing which to use: do you have a vfsmount, or are you "inside" the filesystem. A related question is "is permission checking relevant here?". nfsd and cachefiles *do* have a vfsmount but *don't* use the non-_len functions. They pass nop_mnt_idmap and refuse to work on filesystems which have any other idmap. This series changes nfsd and cachefile to use the lookup_one family of functions and to explictily pass &nop_mnt_idmap which is consistent with all other vfs interfaces used where &nop_mnt_idmap is explicitly passed. The remaining uses of the "_one" functions do not require permission checks so these are renamed to be "_noperm" and the permission checking is removed. This series also changes these lookup function to take a qstr instead of separate name and len. In many cases this simplifies the call. * patches from https://lore.kernel.org/r/20250319031545.2999807-2-neil@brown.name: VFS: change lookup_one_common and lookup_noperm_common to take a qstr Use try_lookup_noperm() instead of d_hash_and_lookup() outside of VFS VFS: rename lookup_one_len family to lookup_noperm and remove permission check cachefiles: Use lookup_one() rather than lookup_one_len() nfsd: Use lookup_one() rather than lookup_one_len() VFS: improve interface for lookup_one functions Link: https://lore.kernel.org/r/20250319031545.2999807-2-neil@brown.name Signed-off-by: Christian Brauner <brauner@kernel.org>
Diffstat (limited to 'drivers/android')
-rw-r--r--drivers/android/binderfs.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c
index 94c6446604fc..98da8c4eea59 100644
--- a/drivers/android/binderfs.c
+++ b/drivers/android/binderfs.c
@@ -187,7 +187,7 @@ static int binderfs_binder_device_create(struct inode *ref_inode,
inode_lock(d_inode(root));
/* look it up */
- dentry = lookup_one_len(name, root, name_len);
+ dentry = lookup_noperm(&QSTR(name), root);
if (IS_ERR(dentry)) {
inode_unlock(d_inode(root));
ret = PTR_ERR(dentry);
@@ -487,7 +487,7 @@ static struct dentry *binderfs_create_dentry(struct dentry *parent,
{
struct dentry *dentry;
- dentry = lookup_one_len(name, parent, strlen(name));
+ dentry = lookup_noperm(&QSTR(name), parent);
if (IS_ERR(dentry))
return dentry;