diff options
| author | Brigham Campbell <me@brighamcampbell.com> | 2025-07-30 21:23:41 -0600 |
|---|---|---|
| committer | Neil Armstrong <neil.armstrong@linaro.org> | 2025-08-04 17:29:38 +0200 |
| commit | 125459e19ec654924e472f3ff5aeea40358dbebf (patch) | |
| tree | fdb6872215e4e54bda074049d49a77c4b98d31e7 /drivers/gpu/drm | |
| parent | drm: panel: Add support for Hydis HV101HD1 MIPI DSI panel (diff) | |
| download | linux-125459e19ec654924e472f3ff5aeea40358dbebf.tar.gz linux-125459e19ec654924e472f3ff5aeea40358dbebf.zip | |
drm/panel: novatek-nt35560: Fix invalid return value
Fix bug in nt35560_set_brightness() which causes the function to
erroneously report an error. mipi_dsi_dcs_write() returns either a
negative value when an error occurred or a positive number of bytes
written when no error occurred. The buggy code reports an error under
either condition.
Fixes: 8152c2bfd780 ("drm/panel: Add driver for Sony ACX424AKP panel")
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Brigham Campbell <me@brighamcampbell.com>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20250731032343.1258366-2-me@brighamcampbell.com
Diffstat (limited to 'drivers/gpu/drm')
| -rw-r--r-- | drivers/gpu/drm/panel/panel-novatek-nt35560.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/panel/panel-novatek-nt35560.c b/drivers/gpu/drm/panel/panel-novatek-nt35560.c index 98f0782c8411..17898a29efe8 100644 --- a/drivers/gpu/drm/panel/panel-novatek-nt35560.c +++ b/drivers/gpu/drm/panel/panel-novatek-nt35560.c @@ -161,7 +161,7 @@ static int nt35560_set_brightness(struct backlight_device *bl) par = 0x00; ret = mipi_dsi_dcs_write(dsi, MIPI_DCS_WRITE_CONTROL_DISPLAY, &par, 1); - if (ret) { + if (ret < 0) { dev_err(nt->dev, "failed to disable display backlight (%d)\n", ret); return ret; } |