aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/gpu
diff options
context:
space:
mode:
authorAlexandre Courbot <acourbot@nvidia.com>2025-07-18 16:26:13 +0900
committerAlexandre Courbot <acourbot@nvidia.com>2025-08-15 12:02:55 +0900
commite40d2b26167200b99fa4fb1df15d4c870489c82e (patch)
tree609e1d2270727472406a69ecb189e1181d7dc011 /drivers/gpu
parentgpu: nova-core: register: move OFFSET declaration to I/O impl block (diff)
downloadlinux-e40d2b26167200b99fa4fb1df15d4c870489c82e.tar.gz
linux-e40d2b26167200b99fa4fb1df15d4c870489c82e.zip
gpu: nova-core: register: fix documentation and indentation
Fix a few documentation inconsistencies, and harmonize indentation where possible. Reviewed-by: Daniel Almeida <daniel.almeida@collabora.com> Reviewed-by: Lyude Paul <lyude@redhat.com> Link: https://lore.kernel.org/r/20250718-nova-regs-v2-8-7b6a762aa1cd@nvidia.com Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Diffstat (limited to 'drivers/gpu')
-rw-r--r--drivers/gpu/nova-core/regs/macros.rs34
1 files changed, 9 insertions, 25 deletions
diff --git a/drivers/gpu/nova-core/regs/macros.rs b/drivers/gpu/nova-core/regs/macros.rs
index 3d4476cc2421..5b3a320de1d3 100644
--- a/drivers/gpu/nova-core/regs/macros.rs
+++ b/drivers/gpu/nova-core/regs/macros.rs
@@ -87,44 +87,28 @@
/// providing its own `completed` field.
macro_rules! register {
// Creates a register at a fixed offset of the MMIO space.
- (
- $name:ident @ $offset:literal $(, $comment:literal)? {
- $($fields:tt)*
- }
- ) => {
+ ($name:ident @ $offset:literal $(, $comment:literal)? { $($fields:tt)* } ) => {
register!(@common $name $(, $comment)?);
register!(@field_accessors $name { $($fields)* });
register!(@io $name @ $offset);
};
- // Creates a alias register of fixed offset register `alias` with its own fields.
- (
- $name:ident => $alias:ident $(, $comment:literal)? {
- $($fields:tt)*
- }
- ) => {
+ // Creates an alias register of fixed offset register `alias` with its own fields.
+ ($name:ident => $alias:ident $(, $comment:literal)? { $($fields:tt)* } ) => {
register!(@common $name $(, $comment)?);
register!(@field_accessors $name { $($fields)* });
register!(@io $name @ $alias::OFFSET);
};
// Creates a register at a relative offset from a base address.
- (
- $name:ident @ + $offset:literal $(, $comment:literal)? {
- $($fields:tt)*
- }
- ) => {
+ ($name:ident @ + $offset:literal $(, $comment:literal)? { $($fields:tt)* } ) => {
register!(@common $name $(, $comment)?);
register!(@field_accessors $name { $($fields)* });
register!(@io $name @ + $offset);
};
- // Creates a alias register of relative offset register `alias` with its own fields.
- (
- $name:ident => + $alias:ident $(, $comment:literal)? {
- $($fields:tt)*
- }
- ) => {
+ // Creates an alias register of relative offset register `alias` with its own fields.
+ ($name:ident => + $alias:ident $(, $comment:literal)? { $($fields:tt)* } ) => {
register!(@common $name $(, $comment)?);
register!(@field_accessors $name { $($fields)* });
register!(@io $name @ + $alias::OFFSET);
@@ -259,7 +243,7 @@ macro_rules! register {
{ |f| <$into_type>::from(f as $type) } $into_type => $into_type $(, $comment)?;);
};
- // Shortcut for fields defined as non-`bool` without the `=>` or `?=>` syntax.
+ // Shortcut for non-boolean fields defined without the `=>` or `?=>` syntax.
(
@field_accessor $name:ident $hi:tt:$lo:tt $field:ident as $type:tt
$(, $comment:literal)?;
@@ -310,7 +294,7 @@ macro_rules! register {
);
};
- // Creates the IO accessors for a fixed offset register.
+ // Generates the IO accessors for a fixed offset register.
(@io $name:ident @ $offset:expr) => {
#[allow(dead_code)]
impl $name {
@@ -344,7 +328,7 @@ macro_rules! register {
}
};
- // Create the IO accessors for a relative offset register.
+ // Generates the IO accessors for a relative offset register.
(@io $name:ident @ + $offset:literal) => {
#[allow(dead_code)]
impl $name {