diff options
| author | Dmitry Torokhov <dmitry.torokhov@gmail.com> | 2024-09-04 21:17:09 -0700 |
|---|---|---|
| committer | Dmitry Torokhov <dmitry.torokhov@gmail.com> | 2024-10-04 00:58:15 -0700 |
| commit | bf46a2c73f867767afa378be5f00fa99d7f5c73c (patch) | |
| tree | 9e147f2f9b01df6e4e348b36f2526dcd4bb8c63a /drivers/input/mouse | |
| parent | Input: alps - use guard notation when pausing serio port (diff) | |
| download | linux-bf46a2c73f867767afa378be5f00fa99d7f5c73c.tar.gz linux-bf46a2c73f867767afa378be5f00fa99d7f5c73c.zip | |
Input: byd - use guard notation when pausing serio port
Using guard notation makes the code more compact and error handling
more robust by ensuring that serio ports are resumed in all code paths
when control leaves critical section.
Link: https://lore.kernel.org/r/20240905041732.2034348-5-dmitry.torokhov@gmail.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Diffstat (limited to 'drivers/input/mouse')
| -rw-r--r-- | drivers/input/mouse/byd.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/input/mouse/byd.c b/drivers/input/mouse/byd.c index 221a553f45cd..654b38d249f3 100644 --- a/drivers/input/mouse/byd.c +++ b/drivers/input/mouse/byd.c @@ -254,13 +254,12 @@ static void byd_clear_touch(struct timer_list *t) struct byd_data *priv = from_timer(priv, t, timer); struct psmouse *psmouse = priv->psmouse; - serio_pause_rx(psmouse->ps2dev.serio); + guard(serio_pause_rx)(psmouse->ps2dev.serio); + priv->touch = false; byd_report_input(psmouse); - serio_continue_rx(psmouse->ps2dev.serio); - /* * Move cursor back to center of pad when we lose touch - this * specifically improves user experience when moving cursor with one |