diff options
| author | Eric Dumazet <edumazet@google.com> | 2024-08-27 01:52:49 +0000 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2024-08-28 17:08:16 -0700 |
| commit | 3e5cbbb1fb9a64588a2c6ddc5e432a303d36a488 (patch) | |
| tree | 8efed836d67b210fa4edf00c60f494fb8380d4b8 /include/net | |
| parent | net/xen-netback: prevent UAF in xenvif_flush_hash() (diff) | |
| download | linux-3e5cbbb1fb9a64588a2c6ddc5e432a303d36a488.tar.gz linux-3e5cbbb1fb9a64588a2c6ddc5e432a303d36a488.zip | |
tcp: remove volatile qualifier on tw_substate
Using a volatile qualifier for a specific struct field is unusual.
Use instead READ_ONCE()/WRITE_ONCE() where necessary.
tcp_timewait_state_process() can change tw_substate while other
threads are reading this field.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Jason Xing <kerneljasonxing@gmail.com>
Link: https://patch.msgid.link/20240827015250.3509197-2-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'include/net')
| -rw-r--r-- | include/net/inet_timewait_sock.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/net/inet_timewait_sock.h b/include/net/inet_timewait_sock.h index f88b68269012..beb533a0e880 100644 --- a/include/net/inet_timewait_sock.h +++ b/include/net/inet_timewait_sock.h @@ -58,7 +58,7 @@ struct inet_timewait_sock { #define tw_dr __tw_common.skc_tw_dr __u32 tw_mark; - volatile unsigned char tw_substate; + unsigned char tw_substate; unsigned char tw_rcv_wscale; /* Socket demultiplex comparisons on incoming packets. */ |