diff options
| author | Juri Lelli <juri.lelli@redhat.com> | 2025-06-27 13:51:15 +0200 |
|---|---|---|
| committer | Peter Zijlstra <peterz@infradead.org> | 2025-07-14 10:59:32 +0200 |
| commit | fcc9276c4d331cd1fe9319d793e80b02e09727f5 (patch) | |
| tree | c66f2ee7ba0c16f78861759de90f065c59379b1d /kernel | |
| parent | sched/deadline: Initialize dl_servers after SMP (diff) | |
| download | linux-fcc9276c4d331cd1fe9319d793e80b02e09727f5.tar.gz linux-fcc9276c4d331cd1fe9319d793e80b02e09727f5.zip | |
sched/deadline: Reset extra_bw to max_bw when clearing root domains
dl_clear_root_domain() doesn't take into account the fact that per-rq
extra_bw variables retain values computed before root domain changes,
resulting in broken accounting.
Fix it by resetting extra_bw to max_bw before restoring back dl-servers
contributions.
Fixes: 2ff899e351643 ("sched/deadline: Rebuild root domain accounting after every update")
Reported-by: Marcel Ziswiler <marcel.ziswiler@codethink.co.uk>
Signed-off-by: Juri Lelli <juri.lelli@redhat.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Tested-by: Marcel Ziswiler <marcel.ziswiler@codethink.co.uk> # nuc & rock5b
Link: https://lore.kernel.org/r/20250627115118.438797-3-juri.lelli@redhat.com
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/sched/deadline.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c index 0d25553f2c17..0abffe3860e3 100644 --- a/kernel/sched/deadline.c +++ b/kernel/sched/deadline.c @@ -2924,7 +2924,14 @@ void dl_clear_root_domain(struct root_domain *rd) int i; guard(raw_spinlock_irqsave)(&rd->dl_bw.lock); + + /* + * Reset total_bw to zero and extra_bw to max_bw so that next + * loop will add dl-servers contributions back properly, + */ rd->dl_bw.total_bw = 0; + for_each_cpu(i, rd->span) + cpu_rq(i)->dl.extra_bw = cpu_rq(i)->dl.max_bw; /* * dl_servers are not tasks. Since dl_add_task_root_domain ignores |