diff options
| author | Jakub Kicinski <kuba@kernel.org> | 2025-04-07 11:00:04 -0700 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2025-04-07 11:00:04 -0700 |
| commit | cf46e18efdd55107315ce874f4638591aabbab6b (patch) | |
| tree | fe6898446bdc67b017d4adeda340c62b6692149a /net | |
| parent | Merge tag 'net-6.15-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/net... (diff) | |
| parent | selftests: drv-net: test random value for hds-thresh (diff) | |
| download | linux-cf46e18efdd55107315ce874f4638591aabbab6b.tar.gz linux-cf46e18efdd55107315ce874f4638591aabbab6b.zip | |
Merge branch 'fix-wrong-hds-thresh-value-setting'
Taehee Yoo says:
====================
fix wrong hds-thresh value setting
A hds-thresh value is not set correctly if input value is 0.
The cause is that ethtool_ringparam_get_cfg(), which is a internal
function that returns ringparameters from both ->get_ringparam() and
dev->cfg can't return a correct hds-thresh value.
The first patch fixes ethtool_ringparam_get_cfg() to set hds-thresh
value correcltly.
The second patch adds random test for hds-thresh value.
So that we can test 0 value for a hds-thresh properly.
====================
Link: https://patch.msgid.link/20250404122126.1555648-1-ap420073@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net')
| -rw-r--r-- | net/ethtool/common.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/ethtool/common.c b/net/ethtool/common.c index 0cb6da1f692a..49bea6b45bd5 100644 --- a/net/ethtool/common.c +++ b/net/ethtool/common.c @@ -830,6 +830,7 @@ void ethtool_ringparam_get_cfg(struct net_device *dev, /* Driver gives us current state, we want to return current config */ kparam->tcp_data_split = dev->cfg->hds_config; + kparam->hds_thresh = dev->cfg->hds_thresh; } static void ethtool_init_tsinfo(struct kernel_ethtool_ts_info *info) |