aboutsummaryrefslogtreecommitdiffstats
path: root/tools/perf/scripts/python/flamegraph.py
diff options
context:
space:
mode:
authorHans de Goede <hdegoede@redhat.com>2021-11-23 22:04:20 +0100
committerHans de Goede <hdegoede@redhat.com>2021-11-25 16:21:25 +0100
commit2f5ad08f3eec8d4376b62f3fe708102f6aaea056 (patch)
treecaf68e511b1123e18657be6ac2c20d6c92b14483 /tools/perf/scripts/python/flamegraph.py
parentplatform/x86: thinkpad_acpi: Restore missing hotkey_tablet_mode and hotkey_ra... (diff)
downloadlinux-2f5ad08f3eec8d4376b62f3fe708102f6aaea056.tar.gz
linux-2f5ad08f3eec8d4376b62f3fe708102f6aaea056.zip
platform/x86: thinkpad_acpi: Register tpacpi_pdriver after subdriver init
Commit 79f960e29cfc ("platform/x86: thinkpad_acpi: Convert platform driver to use dev_groups") introduces the use of driver.dev_groups + attribute_group.is_visible callbacks replacing the conditional calling of driver_create_file() for optional attributes. The is_visible callbacks rely on various tp_features.has_foo flags, which get set by the subdriver init functions. But before this fix, thinkpad_acpi_module_init() would call the subdriver init functions after registering the platform_device and the tpacpi_pdriver. Which would cause the is_visible callbacks to get called before the subdriver init functions, which in turn would cause optional attributes to not get registered at all, even when the feature is actually present. Fix this by moving the platform_driver_register(&tpacpi_pdriver) to after the subdriver init calls; and do the same for the tpacpi_hmon_pdriver. Fixes: 79f960e29cfc ("platform/x86: thinkpad_acpi: Convert platform driver to use dev_groups") Cc: Len Baker <len.baker@gmx.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com> Link: https://lore.kernel.org/r/20211123210424.266607-3-hdegoede@redhat.com
Diffstat (limited to 'tools/perf/scripts/python/flamegraph.py')
0 files changed, 0 insertions, 0 deletions