diff options
| author | Jakub Kicinski <kuba@kernel.org> | 2026-01-29 19:38:27 -0800 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2026-01-31 12:35:27 -0800 |
| commit | fdf3f6800be36377e045e2448087f12132b88d2f (patch) | |
| tree | 820b5ab869b1c58ad0408e2de3102b3e49a6b80b /tools/perf/scripts/python/parallel-perf.py | |
| parent | net: usb: r8152: fix resume reset deadlock (diff) | |
| download | linux-fdf3f6800be36377e045e2448087f12132b88d2f.tar.gz linux-fdf3f6800be36377e045e2448087f12132b88d2f.zip | |
net: don't touch dev->stats in BPF redirect paths
Gal reports that BPF redirect increments dev->stats.tx_errors
on failure. This is not correct, most modern drivers completely
ignore dev->stats so these drops will be invisible to the user.
Core code should use the dedicated core stats which are folded
into device stats in dev_get_stats().
Note that we're switching from tx_errors to tx_dropped.
Core only has tx_dropped, hence presumably users already expect
that counter to increment for "stack" Tx issues.
Reported-by: Gal Pressman <gal@nvidia.com>
Link: https://lore.kernel.org/c5df3b60-246a-4030-9c9a-0a35cd1ca924@nvidia.com
Fixes: b4ab31414970 ("bpf: Add redirect_neigh helper as redirect drop-in")
Acked-by: Martin KaFai Lau <martin.lau@kernel.org>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://patch.msgid.link/20260130033827.698841-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'tools/perf/scripts/python/parallel-perf.py')
0 files changed, 0 insertions, 0 deletions
