diff options
| author | David Lechner <dlechner@baylibre.com> | 2025-03-10 15:43:07 -0500 |
|---|---|---|
| committer | Jonathan Cameron <Jonathan.Cameron@huawei.com> | 2025-04-07 19:34:11 +0100 |
| commit | 15ffee89c7c6d8ac3509e301dd29bab687323133 (patch) | |
| tree | b0ccfc0183788fa2e93d93aa9a4ee5182d07fd80 /tools/perf/scripts/python/stackcollapse.py | |
| parent | efaa981e679ac0cbc8d89b69aa4595e422826329 (diff) | |
| download | linux-15ffee89c7c6d8ac3509e301dd29bab687323133.tar.gz linux-15ffee89c7c6d8ac3509e301dd29bab687323133.zip | |
iio: adc: ad4030: don't store scan_type in state
Move getting the scan_type to ad4030_conversion(). Previously, we were
getting the scan_type in two other places, then storing it in the
state struct before using it in ad4030_conversion(). This was a bit
fragile against potential future changes since it isn't obvious that
anything that could potentially change the scan_type would need to
also update the state struct. Also, the non-obviousness of this led to
a redundant call to iio_get_current_scan_type() in
ad4030_single_conversion() since it also calls ad4030_set_mode() which
in turn calls ad4030_conversion().
To simplify things, just call iio_get_current_scan_type() in
ad4030_conversion() where the returned struct is actually used and
don't bother storing it in the state struct.
Signed-off-by: David Lechner <dlechner@baylibre.com>
Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Link: https://patch.msgid.link/20250310-iio-adc-ad4030-check-scan-type-err-v1-4-589e4ebd9711@baylibre.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Diffstat (limited to 'tools/perf/scripts/python/stackcollapse.py')
0 files changed, 0 insertions, 0 deletions
