diff options
| author | Mehul Rao <mehulrao@gmail.com> | 2026-03-06 18:38:20 -0500 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2026-03-09 18:48:26 -0700 |
| commit | b2662e7593e94ae09b1cf7ee5f09160a3612bcb2 (patch) | |
| tree | a4c619feec1b30171d952e467ef3183e6cec09ab /tools/perf/scripts/python/task-analyzer.py | |
| parent | 288598d80a068a0e9281de35bcb4ce495f189e2a (diff) | |
| download | linux-b2662e7593e94ae09b1cf7ee5f09160a3612bcb2.tar.gz linux-b2662e7593e94ae09b1cf7ee5f09160a3612bcb2.zip | |
net: nexthop: fix percpu use-after-free in remove_nh_grp_entry
When removing a nexthop from a group, remove_nh_grp_entry() publishes
the new group via rcu_assign_pointer() then immediately frees the
removed entry's percpu stats with free_percpu(). However, the
synchronize_net() grace period in the caller remove_nexthop_from_groups()
runs after the free. RCU readers that entered before the publish still
see the old group and can dereference the freed stats via
nh_grp_entry_stats_inc() -> get_cpu_ptr(nhge->stats), causing a
use-after-free on percpu memory.
Fix by deferring the free_percpu() until after synchronize_net() in the
caller. Removed entries are chained via nh_list onto a local deferred
free list. After the grace period completes and all RCU readers have
finished, the percpu stats are safely freed.
Fixes: f4676ea74b85 ("net: nexthop: Add nexthop group entry stats")
Cc: stable@vger.kernel.org
Signed-off-by: Mehul Rao <mehulrao@gmail.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Link: https://patch.msgid.link/20260306233821.196789-1-mehulrao@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'tools/perf/scripts/python/task-analyzer.py')
0 files changed, 0 insertions, 0 deletions
