diff options
| author | Chengming Zhou <zhouchengming@bytedance.com> | 2022-12-23 18:32:56 +0800 |
|---|---|---|
| committer | Ingo Molnar <mingo@kernel.org> | 2023-01-07 10:48:38 +0100 |
| commit | efe09385864f3441c71711f91e621992f9423c01 (patch) | |
| tree | 0b20f5306a815bec98486aaf2b71e34018dc6a5a /tools/perf/scripts/python/task-analyzer.py | |
| parent | sched/documentation: Document the util clamp feature (diff) | |
| download | linux-efe09385864f3441c71711f91e621992f9423c01.tar.gz linux-efe09385864f3441c71711f91e621992f9423c01.zip | |
sched/core: Micro-optimize ttwu_runnable()
ttwu_runnable() is used as a fast wakeup path when the wakee task
is running on CPU or runnable on RQ, in both cases we can just
set its state to TASK_RUNNING to prevent a sleep.
If the wakee task is on_cpu running, we don't need to update_rq_clock()
or check_preempt_curr().
But if the wakee task is on_rq && !on_cpu (e.g. an IRQ hit before
the task got to schedule() and the task been preempted), we should
check_preempt_curr() to see if it can preempt the current running.
This also removes the class->task_woken() callback from ttwu_runnable(),
which wasn't required per the RT/DL implementations: any required push
operation would have been queued during class->set_next_task() when p
got preempted.
ttwu_runnable() also loses the update to rq->idle_stamp, as by definition
the rq cannot be idle in this scenario.
Suggested-by: Valentin Schneider <vschneid@redhat.com>
Suggested-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Valentin Schneider <vschneid@redhat.com>
Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Link: https://lore.kernel.org/r/20221223103257.4962-1-zhouchengming@bytedance.com
Diffstat (limited to 'tools/perf/scripts/python/task-analyzer.py')
0 files changed, 0 insertions, 0 deletions
