diff options
| author | Lucas De Marchi <lucas.demarchi@intel.com> | 2019-11-27 14:11:21 -0800 |
|---|---|---|
| committer | Lucas De Marchi <lucas.demarchi@intel.com> | 2019-12-02 10:06:25 -0800 |
| commit | 13caf7bea4432e8d192d412eae9ee8efb2f47fe8 (patch) | |
| tree | b5f87cb9bca2889d2b407be8fd57e56e780aeea1 /tools/perf/scripts/python | |
| parent | ca851c224853fb0eb6e4f45c92896f89e6013a44 (diff) | |
| download | linux-13caf7bea4432e8d192d412eae9ee8efb2f47fe8.tar.gz linux-13caf7bea4432e8d192d412eae9ee8efb2f47fe8.zip | |
drm/i915/dsb: fix cmd_buf being wrongly set
The "err" label is not really "err", but rather "out" since the return
path is shared between error condition and normal path. This broke when
commit 03cea61076f0 ("drm/i915/dsb: fix extra warning on error path
handling") added a "dsb->cmd_buf = NULL;" there, making DSB to stop
working since now all writes would pass-through via mmio.
Remove the set to NULL since it's actually not needed: we only set it if
all steps are successful. While at it, rename the label so this confusion
doesn't happen again.
Fixes: 03cea61076f0 ("drm/i915/dsb: fix extra warning on error path handling")
Resolves: https://gitlab.freedesktop.org/drm/intel/issues/8
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Animesh Manna <animesh.manna@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191127221119.384754-1-lucas.demarchi@intel.com
Diffstat (limited to 'tools/perf/scripts/python')
0 files changed, 0 insertions, 0 deletions