diff options
| author | Sean Christopherson <seanjc@google.com> | 2021-10-08 19:12:00 -0700 |
|---|---|---|
| committer | Paolo Bonzini <pbonzini@redhat.com> | 2021-12-08 04:24:48 -0500 |
| commit | 30c9434717fd27e634a157dcdee286703b1f4891 (patch) | |
| tree | 9394f3807474a3f1892808948cc71bb132ca77ab /tools/perf/scripts/python | |
| parent | KVM: Refactor and document halt-polling stats update helper (diff) | |
| download | linux-30c9434717fd27e634a157dcdee286703b1f4891.tar.gz linux-30c9434717fd27e634a157dcdee286703b1f4891.zip | |
KVM: Reconcile discrepancies in halt-polling stats
Move the halt-polling "success" and histogram stats update into the
dedicated helper to fix a discrepancy where the success/fail "time" stats
consider polling successful so long as the wait is avoided, but the main
"success" and histogram stats consider polling successful if and only if
a wake event was detected by the halt-polling loop.
Move halt_attempted_poll to the helper as well so that all the stats are
updated in a single location. While it's a bit odd to update the stat
well after the fact, practically speaking there's no meaningful advantage
to updating before polling.
Note, there is a functional change in addition to the success vs. fail
change. The histogram updates previously called ktime_get() instead of
using "cur". But that change is desirable as it means all the stats are
now updated with the same polling time, and avoids the extra ktime_get(),
which isn't expensive but isn't free either.
Reviewed-by: David Matlack <dmatlack@google.com>
Signed-off-by: Sean Christopherson <seanjc@google.com>
Message-Id: <20211009021236.4122790-8-seanjc@google.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'tools/perf/scripts/python')
0 files changed, 0 insertions, 0 deletions
