diff options
| author | Hans de Goede <hdegoede@redhat.com> | 2022-10-23 21:22:14 +0100 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@kernel.org> | 2022-11-25 08:19:24 +0000 |
| commit | da0dd507fa279c33813ae6f28e47c61ce065586c (patch) | |
| tree | 461e3fb646dbeaaf2826c27bbb1260c19f53a7cd /tools/perf/scripts/python | |
| parent | media: atomisp: Log an error on failing to alloc private-mem (diff) | |
| download | linux-da0dd507fa279c33813ae6f28e47c61ce065586c.tar.gz linux-da0dd507fa279c33813ae6f28e47c61ce065586c.zip | |
media: atomisp: Fix deadlock when the /dev/video# node is closed while still streaming
atomisp_release() was taking pipe->vb_queue_mutex + isp->mutex at the
same time. But if the /dev/video# node is closed while still streaming
then vb2_queue_release() will call atomisp_stop_streaming() which takes
isp->mutex itself, leading to a deadlock.
To fix this only take isp->mutex after cleaning up the v4l2_fh /
the vb2_queue. While at it switch to vb2_fop_release() which will take
pipe->vb_queue_mutex for us, which also resolves a FIXME comment.
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Diffstat (limited to 'tools/perf/scripts/python')
0 files changed, 0 insertions, 0 deletions