diff options
| author | Boris Burkov <boris@bur.io> | 2023-07-21 09:02:06 -0700 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2023-08-21 14:52:13 +0200 |
| commit | e28b02118b94e42be3355458a2406c6861e2dd32 (patch) | |
| tree | ec641d424bfc0096f1c2c708a4ec389e9eb9ae20 /tools/perf/scripts/python | |
| parent | btrfs: remove duplicate free_async_extent_pages() on reservation error (diff) | |
| download | linux-e28b02118b94e42be3355458a2406c6861e2dd32.tar.gz linux-e28b02118b94e42be3355458a2406c6861e2dd32.zip | |
btrfs: free qgroup rsv on io failure
If we do a write whose bio suffers an error, we will never reclaim the
qgroup reserved space for it. We allocate the space in the write_iter
codepath, then release the reservation as we allocate the ordered
extent, but we only create a delayed ref if the ordered extent finishes.
If it has an error, we simply leak the rsv. This is apparent in running
any error injecting (dmerror) fstests like btrfs/146 or btrfs/160. Such
tests fail due to dmesg on umount complaining about the leaked qgroup
data space.
When we clean up other aspects of space on failed ordered_extents, also
free the qgroup rsv.
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
CC: stable@vger.kernel.org # 5.10+
Signed-off-by: Boris Burkov <boris@bur.io>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'tools/perf/scripts/python')
0 files changed, 0 insertions, 0 deletions