diff options
| author | Ian Rogers <irogers@google.com> | 2025-03-05 11:19:31 -0800 |
|---|---|---|
| committer | Namhyung Kim <namhyung@kernel.org> | 2025-03-06 15:59:41 -0800 |
| commit | 2c744f38da7aeae77f9fc220a538fe8ca88f6db4 (patch) | |
| tree | 4dcf02a5add793139e9661131b8aff1b4fbf298a /tools/perf/tests | |
| parent | perf machine: Fix insertion of PERF_RECORD_KSYMBOL related kernel maps (diff) | |
| download | linux-2c744f38da7aeae77f9fc220a538fe8ca88f6db4.tar.gz linux-2c744f38da7aeae77f9fc220a538fe8ca88f6db4.zip | |
perf test: Fix leak in "Synthesize attr update" test
The own_cpus map variable may be non-NULL and hold a reference, in
particular on hybrid machines. Do a put before overwriting the
variable to avoid a memory leak.
Signed-off-by: Ian Rogers <irogers@google.com>
Reviewed-by: James Clark <james.clark@linaro.org>
Link: https://lore.kernel.org/r/20250305191931.604764-1-irogers@google.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Diffstat (limited to 'tools/perf/tests')
| -rw-r--r-- | tools/perf/tests/event_update.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/tools/perf/tests/event_update.c b/tools/perf/tests/event_update.c index d6b4ce3ef4ee..9301fde11366 100644 --- a/tools/perf/tests/event_update.c +++ b/tools/perf/tests/event_update.c @@ -109,6 +109,7 @@ static int test__event_update(struct test_suite *test __maybe_unused, int subtes TEST_ASSERT_VAL("failed to synthesize attr update name", !perf_event__synthesize_event_update_name(&tmp.tool, evsel, process_event_name)); + perf_cpu_map__put(evsel->core.own_cpus); evsel->core.own_cpus = perf_cpu_map__new("1,2,3"); TEST_ASSERT_VAL("failed to synthesize attr update cpus", |